I tried out this implementation of TD-PSOLA (https://github.com/sannawag/TD-PSOLA) and even though I know how the algorithm works, I can't understand why I get NO audible differences in the output when using f_ratio = 0.5, given that f_ratio = f_new/f_orig.

I've tried printing the length of 'peaks' (that would be the total number of peaks) arrays from both, the original signal and the new signal, by using find_peaks() again after shift_pitch() returns the output. I got these results:

f_ratio                            #orig_peaks                    #new_peaks
1                                    417                            416
0.9                                  417                            389
0.8                                  417                            403
0.7                                  417                            396
0.6                                  417                            324
0.5                                  417                            404

This looks completely nonsense to me.

I've already tried using another windows (numpy's Hamming, Hanning). Of course, it has to have something to do with the overlap-and-add process...right?

Any help would be greatly appreciated.

  • $\begingroup$ The audio that are you using to test are in somewhere ? We can listen ? $\endgroup$ – ederwander Nov 5 '19 at 11:35
  • $\begingroup$ As I can't upload the files, the easiest thing to do is to run the .py itself I guess :( $\endgroup$ – Rama Feichu Nov 11 '19 at 23:11
  • $\begingroup$ I have implemented this algorithm in matlab and C, my code works great for monophonics sounds, maybe the Pitch Track from this python code fails(is just one basic autocorrelation code), to this code works nice in a large number of monophonics sound, you need a ultra super power pitch track algorithm, you can see my code working here $\endgroup$ – ederwander Nov 12 '19 at 10:44

I believe you're correct, it's an issue with the overlap-add process. The code doesn't correctly calculate the triangular windows for lower pitches.

In short, the windows are too big.

It produces incorrect results for any pitch ratio below 1, such as 0.5 (one octave down).

The diagram below explains the issue as I understand it: TD-PSOLA Diagram, the window widths are stretched too much

The big windows introduce so many artifacts (additional peaks) that the result sounds almost exactly the same, apart from the "speaking into fan" effect.

To get around this, it would be easiest to add an if statement which would use the existing windows only when the pitch ratio is equal or greater than 1, otherwise it should use the 'ideal windows'.

However, I'm not sure to implement the 'ideal windows' in Python. The existing algorithm uses newPeaks to calculate windows. For lower pitches it must use the old peaks array. However, this requires new math which I'm not sure how to implement exactly.

| improve this answer | |

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.